Add pipeline() function #451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This involved some refactoring of the tests for compose(), so that we can programmatically ensure that compose() and pipeline() have equivalent tests.
This unfortunately removes ability of parametrized tests to fail independently, but is necessary so that CI tests will pass
Closed
chuckwondo
reviewed
Jul 1, 2019
Member
|
LGTM! Thanks for your effort and patience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fulfils #369.
pipeline()function, which is equivalent tocompose(), but with the functions composed left-to-right.pipeline()function.compose(), so that we can programmatically ensure thatcompose()andpipeline()have equivalent tests.